fix(lapis): don't show the single segmented sequence download when there are no nucleotide sequences #1054
Conversation
…ere are no nucleotide sequences In the context of loculus-project/loculus#3388
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.3.11 (2025-01-17)Bug Fixes |
| @@ -41,7 +41,8 @@ import org.springframework.web.bind.annotation.RequestParam | |||
| import org.springframework.web.bind.annotation.RestController | |||
|
|
|||
| const val IS_SINGLE_SEGMENT_SEQUENCE_EXPRESSION = | |||
There was a problem hiding this comment.
Should we rename this variable to something like
| const val IS_SINGLE_SEGMENT_SEQUENCE_EXPRESSION = | |
| const val SHOW_SINGLE_SEGMENTED_CONTROLLER = |
There was a problem hiding this comment.
Is this distinguishing aligned and non-aligned sequences? It should be possible to have one of them and disable the other.
There was a problem hiding this comment.
No, neither LAPIS nor SILO currently distinguish aligned and non-aligned sequences.
In the context of loculus-project/loculus#3388
This will simply show no endpoint to download nucleotide sequences when there are none in the reference genomes. Without this change, it shows the single segmented endpoints that throw index out of bounds exceptions:
LAPIS/lapis/src/main/kotlin/org/genspectrum/lapis/controller/SingleSegmentedSequenceController.kt
Line 109 in c6f625e
PR Checklist
- [ ] All necessary documentation has been adapted.- [ ] The implemented feature is covered by an appropriate test.