Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

echo server example #99

Merged
merged 3 commits into from
Oct 13, 2020
Merged

echo server example #99

merged 3 commits into from
Oct 13, 2020

Conversation

pnwamk
Copy link
Contributor

@pnwamk pnwamk commented Oct 9, 2020

Adds a simple echo server example usage of argo that has simple commands and queries and leverages the server's file reading capabilities.

Potential Remaining Tasks have been moved

  • Add unit tests exercising each error code #31 add some tests for the argo error handling related to invalid JSON-RPC requests? E.g., parse error (-32700), invalid request (-32600), internal error (-32603), and unknown state id (20). N.B., internal error could be tested by just making a query function that simply errors on the example server and calling that at the end of our test suite, but the others might need to circumvent (or get creative with) the python argo API (since the python argo lib tries to avoid making/allowing the other errors I believe)
  • Set up Github Actions #100 incorporate cabal test file-echo-api into our CI for this repo

Copy link
Contributor

@david-christiansen david-christiansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, and I think it'll be a valuable example to have.

One request: we use ReST for all the rest of the docs, due to Sphinx and Python, including the README. Can the docs here be ReST instead of .md?

@david-christiansen
Copy link
Contributor

How about merging this and then converting the remaining tasks into issues?

@pnwamk pnwamk merged commit 5dcb409 into master Oct 13, 2020
@pnwamk pnwamk deleted the feature/echo-server-example branch October 13, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants