Wrong argument to cs_transpose leads to segfault #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite some time ago I fixed a bug in the Debian package of a segfault randomly happening during testing. At the time I determined that the argument to
cs_transpose
was incorrect and caused a segfault randomly during testing.The segfault can be reproduced (without this patch) by setting the random seed in fctst:
Incidentally it's probably not a great idea to have a random number involved in a test.
Anyway, this patch fixes this problem, but I would prefer someone verify the correctness of the fix, as it's rather obscure.
I am now looking at this because I want to update the Siconos package to 4.4.0, but for this we need to have a new fclib release that includes the new functions related to rolling problems.