Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition for Siemens WinCC logs #546

Merged
merged 4 commits into from
Dec 22, 2022

Conversation

meeehow
Copy link
Contributor

@meeehow meeehow commented Dec 21, 2022

This PR creates new ics.yaml file and adds definition for Siemens WinCC software logs.

@joachimmetz
Copy link
Member

@meeehow FYI validation test is failing

======================================================================
FAIL: testArtifactDefinitionsValidator (validator_test.ArtifactDefinitionsValidatorTest)
Runs the validator over all the YAML artifact definitions files.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\projects\artifacts\tests\validator_test.py", line 24, in testArtifactDefinitionsValidator
    self.assertTrue(
AssertionError: False is not true : in definitions file: data\ics.yaml
----------------------------------------------------------------------

@meeehow
Copy link
Contributor Author

meeehow commented Dec 22, 2022

testArtifactDefinitionsValidator (validator_test.ArtifactDefinitionsValidatorTest)
Runs the validator over all the YAML artifact definitions files. ... WARNING:root:Artifact definition: WindowsSiemensWinCCLogFile in file: data/ics.yaml contains Windows path that contains an unuspported environment variable: "%%environ_programdata%%".
WARNING:root:Artifact definition: WindowsSiemensWinCCLogFile in file: data/ics.yaml contains Windows path that contains an unuspported environment variable: "%%environ_programdata%%".
WARNING:root:Artifact definition: WindowsSiemensWinCCLogFile in file: data/ics.yaml contains Windows path that contains an unuspported environment variable: "%%environ_programdata%%".
FAIL

testArtifactDefinitionsValidator is complaining about the %%environ_programdata%% variable, if I delete the lines containing it the tests pass.

@joachimmetz
Copy link
Member

Use %%environ_allusersappdata%% for now this is the pre-Window Vista naming convention and there is an issue pending to change this #339

@joachimmetz joachimmetz self-assigned this Dec 22, 2022
@joachimmetz joachimmetz self-requested a review December 22, 2022 11:35
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #546 (2bf62e3) into main (e8a65ac) will not change coverage.
The diff coverage is n/a.

❗ Current head 2bf62e3 differs from pull request most recent head 260dfa9. Consider uploading reports for the commit 260dfa9 to get more accurate results

@@           Coverage Diff           @@
##             main     #546   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files           7        7           
  Lines         443      443           
=======================================
  Hits          390      390           
  Misses         53       53           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joachimmetz joachimmetz merged commit 2410b09 into ForensicArtifacts:main Dec 22, 2022
Copy link
Member

@joachimmetz joachimmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants