-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add definition for Siemens WinCC logs #546
Conversation
@meeehow FYI validation test is failing
|
testArtifactDefinitionsValidator is complaining about the %%environ_programdata%% variable, if I delete the lines containing it the tests pass. |
Use |
Codecov Report
@@ Coverage Diff @@
## main #546 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 7 7
Lines 443 443
=======================================
Hits 390 390
Misses 53 53 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR creates new ics.yaml file and adds definition for Siemens WinCC software logs.