Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted typo of CurrentControlSet #347

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

marcurdy
Copy link
Contributor

Small change.

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #347 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files           7        7           
  Lines         420      420           
=======================================
  Hits          383      383           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff2ea0c...65219df. Read the comment docs.

@joachimmetz joachimmetz self-requested a review June 12, 2019 03:49
@joachimmetz joachimmetz self-assigned this Jun 12, 2019
@joachimmetz joachimmetz merged commit bf215d2 into ForensicArtifacts:master Jun 12, 2019
@joachimmetz
Copy link
Member

Thx, for the corrections

@marcurdy
Copy link
Contributor Author

marcurdy commented Jun 12, 2019 via email

@joachimmetz
Copy link
Member

Ack, know that plaso directly supports artifacts as collection filters as well

@marcurdy
Copy link
Contributor Author

marcurdy commented Jun 12, 2019 via email

@joachimmetz
Copy link
Member

joachimmetz commented Jun 13, 2019

The first means key with value LocalServer, the second means default value of key. I'll double check but the second could be an error (#348). For GRR historically this does not make a difference because the value is appended to the key path (which can cause issues with e.g. bagmru paths where subkey and value names are the same).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants