Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantity unit conversions #255

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

arcnmx
Copy link

@arcnmx arcnmx commented Aug 31, 2024

This is just a rough attempt at using the amount and quantity configured in grocy's product barcode for purchase and consume amounts. This likely relates to #209/#161/#123. Adding a config toggle that uses the default consume/purchase quantity+amount instead of the barcode's would probably make sense to address #215 as well.

@jtitley
Copy link

jtitley commented Sep 29, 2024

@Forceu bump on this.

@Forceu
Copy link
Owner

Forceu commented Oct 1, 2024

Hi, thanks for the PR. This is still set as draft, is it ready for review?

@arcnmx
Copy link
Author

arcnmx commented Oct 12, 2024

It should at least be ready for a preliminary review - most of the reason that it's marked WIP is because I'm looking for some initial feedback on whether the approach is worth polishing up for submission.
The code itself is basically ready as-is (besides the potential inclusion of settings to customize the behaviours mentioned previously), it mostly just needs some polish and clean-up in the form of formatting and more documentation before I'd consider it "ready".

@gstburnside
Copy link

@arcnmx this will be a great help if I'm following correctly. I am currently creating a number of barcodes on a given product to add/consume "x" quantity units, but scanning them is always adding/consuming the product stock unit instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants