Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use shared jackson-core test-jar, JacksonTestUtilBase #4901

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

cowtowncoder
Copy link
Member

No description provided.

@JooHyukKim
Copy link
Member

Do we get to remove @JacksonFailureExpected annotation and use one from core as well?

@cowtowncoder
Copy link
Member Author

Do we get to remove @JacksonFailureExpected annotation and use one from core as well?

Yes, if all goes well that'd be the idea.

@cowtowncoder
Copy link
Member Author

Hmmmh. It all works beautifully with Maven from command line, but Eclipse is not having any of it and fails to find dependencies. Frustrating... maybe due to test-jar missing module-info.class?

@JooHyukKim
Copy link
Member

Hmmmh. It all works beautifully with Maven from command line, but Eclipse is not having any of it and fails to find dependencies. Frustrating... maybe due to test-jar missing module-info.class?

Strange... Where can I find Eclipse's failing logs?

@cowtowncoder
Copy link
Member Author

Strange... Where can I find Eclipse's failing logs?

I can see it on GUI, not sure where logs would be. But maybe I should try re-exporting jackson-databind project. I am using latest Eclipse.
Should also try to see if/that things works on IntelliJ IDEA.

@cowtowncoder
Copy link
Member Author

If CI passes, will merge in its current form: unit tests work, Eclipse bit wonky but except for "tofix" tests, I can run unit tests from IDE. So that's good enough.

And once merged, will look into "tofix" tests, for them to use shared implementation.

One problem to solve wrt jackson-core: "test-jar" (see target/jackson-core-3.0.0-SNAPSHOT-tests.jar after ./mvnw clean package) is missing /module-info.class` despite:

  • There being src/test/java/module-info.java which
  • gets compiled into target/test-classes/module-info.class
  • but somehow dropped by maven-jar-plugin (possibly due to work-arounds I had to add to make main src/main/java/module-info.java get into main artifact)

@cowtowncoder cowtowncoder merged commit 8cc14a2 into master Jan 16, 2025
6 checks passed
@cowtowncoder cowtowncoder deleted the tatu/3.0/use-jackson-core-testlib branch January 16, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants