-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OkHttp transport module #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # settings.gradle
# Conflicts: # settings.gradle
jordan-n-schmidt
previously approved these changes
Jan 16, 2025
mohnoor94
approved these changes
Jan 16, 2025
jordan-n-schmidt
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
One of the features of the new core module is its flexibility in supporting diverse HTTP clients by allowing end-users or product SDKs to inject their preferred implementations. This is achieved by implementing the
Transport
interface for synchronous requests or theAsyncTransport
interface for asynchronous requests.To achieve full decoupling between the core module and any specific HTTP client library; we will publish packages that integrates different HTTP clients (e.g., OkHttp, Apache HTTP) with the SDK's Transport interfaces. SDK users simply need to include dependencies on both the product SDK and one of the supported HTTP client packages.
In this PR, we are introducing a new module
expediagroup-sdk-okhttp-transport
that offers a ready-to-use Transport implementation using OkHttp.Caution
Changes in this PR are already on the main branch and has been reviewed earlier. This PR extracts all OkHttp-related files to a new module.
Task
Move all OkHttp related files to a separate module.
Action
expediagroup-sdk-okhttp-transport
okhttp
package to the new module.Testing