-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: authentication package unit tests #128
Merged
mohnoor94
merged 4 commits into
main
from
OmarAlJarrah/add-authentication-package-tests
Dec 22, 2024
Merged
test: authentication package unit tests #128
mohnoor94
merged 4 commits into
main
from
OmarAlJarrah/add-authentication-package-tests
Dec 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mohammad-Dwairi
previously approved these changes
Dec 17, 2024
...otlin/com/expediagroup/sdk/core/authentication/bearer/BearerAuthenticationInterceptorTest.kt
Outdated
Show resolved
Hide resolved
...otlin/com/expediagroup/sdk/core/authentication/bearer/BearerAuthenticationInterceptorTest.kt
Outdated
Show resolved
Hide resolved
...st/kotlin/com/expediagroup/sdk/core/authentication/bearer/BearerAuthenticationManagerTest.kt
Outdated
Show resolved
Hide resolved
...st/kotlin/com/expediagroup/sdk/core/authentication/bearer/BearerAuthenticationManagerTest.kt
Outdated
Show resolved
Hide resolved
...st/kotlin/com/expediagroup/sdk/core/authentication/bearer/BearerAuthenticationManagerTest.kt
Outdated
Show resolved
Hide resolved
...st/kotlin/com/expediagroup/sdk/core/authentication/bearer/BearerAuthenticationManagerTest.kt
Outdated
Show resolved
Hide resolved
...st/kotlin/com/expediagroup/sdk/core/authentication/bearer/BearerAuthenticationManagerTest.kt
Outdated
Show resolved
Hide resolved
...st/kotlin/com/expediagroup/sdk/core/authentication/bearer/BearerAuthenticationManagerTest.kt
Outdated
Show resolved
Hide resolved
code/src/test/kotlin/com/expediagroup/sdk/core/authentication/bearer/TokenResponseTest.kt
Outdated
Show resolved
Hide resolved
Mohammad-Dwairi
approved these changes
Dec 22, 2024
mohnoor94
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
At the moment of creating this PR, we do not have unit-tests that cover all components in our new
sdk-core
. The goal of this PR is to add unit-tests that test all files in thecom.expediagroup.sdk.core.authentication
package.Task
Add unit tests using Junit-5 and Mockk.
Action
Added new unit-tests for the following classes:
BearerAuthenticationInterceptor
BearerAuthenticationManager
BearerTokenStorageTest
TokenResponse
Credentials
Testing
NaN
Results
All files in the
com.expediagroup.sdk.core.authentication
package are now tested.Notes
NaN