chore: add unit tests for Headers class #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mdwairi <[email protected]>
…table-http-clients-interfaces
…clients-interfaces
…i/add-authentication-interceptor
…clients-interfaces
…i/add-authentication-interceptor
…d-loggin-interceptor
…into mdwairi/add-authentication-interceptor
… mdwairi/add-loggin-interceptor
…/okhttp-default-client-impl
# Conflicts: # code/build.gradle
…re-tests # Conflicts: # code/build.gradle # code/src/main/kotlin/com/expediagroup/sdk/core/authentication/bearer/BearerAuthenticationInterceptor.kt # code/src/main/kotlin/com/expediagroup/sdk/core/authentication/bearer/BearerAuthenticationManager.kt # code/src/main/kotlin/com/expediagroup/sdk/core/authentication/bearer/BearerTokenStorage.kt # code/src/main/kotlin/com/expediagroup/sdk/core/authentication/bearer/TokenResponse.kt # code/src/main/kotlin/com/expediagroup/sdk/core/authentication/common/AuthenticationManager.kt # code/src/main/kotlin/com/expediagroup/sdk/core/authentication/common/Credentials.kt # code/src/main/kotlin/com/expediagroup/sdk/core/http/MediaType.kt # code/src/main/kotlin/com/expediagroup/sdk/core/http/Status.kt # code/src/main/kotlin/com/expediagroup/sdk/core/interceptor/Interceptor.kt # code/src/main/kotlin/com/expediagroup/sdk/core/interceptor/InterceptorsChainExecutor.kt # code/src/main/kotlin/com/expediagroup/sdk/core/logging/LoggingInterceptor.kt # code/src/main/kotlin/com/expediagroup/sdk/core/logging/common/Constant.kt # code/src/main/kotlin/com/expediagroup/sdk/core/logging/common/LogMessageTag.kt # code/src/main/kotlin/com/expediagroup/sdk/core/logging/common/LoggableContentTypes.kt # code/src/main/kotlin/com/expediagroup/sdk/core/logging/common/LoggerDecorator.kt # code/src/main/kotlin/com/expediagroup/sdk/core/model/exception/client/ExpediaGroupResponseParsingException.kt # code/src/main/kotlin/com/expediagroup/sdk/core/okhttp/BaseOkHttpClient.kt # code/src/main/kotlin/com/expediagroup/sdk/core/okhttp/OkHttpClientConfiguration.kt # code/src/main/kotlin/com/expediagroup/sdk/graphql/common/ApolloAliases.kt # code/src/main/kotlin/com/expediagroup/sdk/graphql/common/ApolloHttpEngine.kt # code/src/main/kotlin/com/expediagroup/sdk/graphql/common/DefaultGraphQLExecutor.kt # code/src/main/kotlin/com/expediagroup/sdk/graphql/common/GraphQLClient.kt # code/src/main/kotlin/com/expediagroup/sdk/lodgingconnectivity/configuration/ClientConfiguration.kt # code/src/main/kotlin/com/expediagroup/sdk/lodgingconnectivity/payment/PaymentClient.kt # code/src/main/kotlin/com/expediagroup/sdk/lodgingconnectivity/sandbox/SandboxDataManagementClient.kt # code/src/main/kotlin/com/expediagroup/sdk/lodgingconnectivity/supply/reservation/ReservationClient.kt
# Conflicts: # code/build.gradle # code/src/main/kotlin/com/expediagroup/sdk/core/http/Headers.kt # code/src/main/kotlin/com/expediagroup/sdk/core/http/RequestBody.kt # code/src/main/kotlin/com/expediagroup/sdk/core/http/ResponseBody.kt
jordan-n-schmidt
previously approved these changes
Dec 4, 2024
mohnoor94
requested changes
Dec 4, 2024
code/src/test/java/com/expediagroup/sdk/core/http/HeadersJavaTest.java
Outdated
Show resolved
Hide resolved
mohnoor94
approved these changes
Dec 4, 2024
jordan-n-schmidt
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
With the introduction of the new SDK core, we need to raise the tests coverage before attempting to migrate the core module to the original repository. We will be testing the new core with this LC SDK during this temporary phase.
Task
HeadersHTTP model class with unit tests.Action
HeadersTestclass containing tests forHeadersclass and its internal builder logic.HeadersJavaTestto cover code generated by annotations like@JvmStatic. The reporting tool fails to detect correct coverage without testing these in Java. Anyway, this could be useful to always be sure of the code accessibility in Java environments.Testing
All new tests are passing.
Results
Headersclass is 100% covered.