Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include memory cache on clear #82

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix: include memory cache on clear #82

merged 1 commit into from
Apr 2, 2024

Conversation

r4vn
Copy link

@r4vn r4vn commented Apr 2, 2024

Summary

This PR resets the private property when calling .clear() for @exodus/keychain at version 5.

Mirror of: #81

@r4vn r4vn added bug Something isn't working keychain labels Apr 2, 2024
@r4vn r4vn requested a review from sparten11740 April 2, 2024 17:34
@r4vn r4vn self-assigned this Apr 2, 2024
@r4vn r4vn merged commit 4dc0e02 into @exodus/keychain@5 Apr 2, 2024
5 checks passed
@r4vn r4vn deleted the r4vn/fix/keychain-cache-clear-v5 branch April 2, 2024 17:41
This was referenced Apr 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvayngrib mvayngrib mvayngrib approved these changes

@sparten11740 sparten11740 Awaiting requested review from sparten11740

@kewde kewde Awaiting requested review from kewde kewde is a code owner

@diegomura diegomura Awaiting requested review from diegomura diegomura is a code owner

Assignees

@r4vn r4vn

Labels
bug Something isn't working feature keychain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r4vn @mvayngrib