feat(sql): Adds url_download and url_upload to daft-sql #3690
+382
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3690 +/- ##
==========================================
- Coverage 77.79% 77.68% -0.11%
==========================================
Files 729 732 +3
Lines 90477 90757 +280
==========================================
+ Hits 70384 70502 +118
- Misses 20093 20255 +162
|
RCHowell
force-pushed
the
rchowell/df-109-add-missing-url_-functions-to-sql
branch
from
6f90f29 to
63ae5b7
Compare
RCHowell
commented
Jan 15, 2025
| Ok(Self { | ||
| max_connections, | ||
| raise_error_on_failure, | ||
| multi_thread: true, // TODO always true |
There was a problem hiding this comment.
I wasn't able to find other examples of multi_thread in daft-sql, but the python logic defined in ExpressionUrlNamespace has
multi_thread = not using_ray_runner
universalmind303
approved these changes
Jan 15, 2025
tests/sql/test_uri_exprs.py
Outdated
Comment on lines
8
to
43
| def test_url_download(): | ||
| df = daft.from_pydict( | ||
| { | ||
| "urls": [ | ||
| "https://raw.githubusercontent.com/Eventual-Inc/Daft/refs/heads/main/README.rst", | ||
| "https://raw.githubusercontent.com/Eventual-Inc/Daft/refs/heads/main/LICENSE", | ||
| ] | ||
| } | ||
| ) | ||
|
|
||
| actual = ( | ||
| daft.sql( | ||
| """ | ||
| SELECT | ||
| url_download(urls) as downloaded, | ||
| url_download(urls, max_connections=>1) as downloaded_single_conn, | ||
| url_download(urls, on_error=>'null') as downloaded_ignore_errors | ||
| FROM df | ||
| """ | ||
| ) | ||
| .collect() | ||
| .to_pydict() | ||
| ) | ||
|
|
||
| expected = ( | ||
| df.select( | ||
| col("urls").url.download().alias("downloaded"), | ||
| col("urls").url.download(max_connections=1).alias("downloaded_single_conn"), | ||
| col("urls").url.download(on_error="null").alias("downloaded_ignore_errors"), | ||
| ) | ||
| .collect() | ||
| .to_pydict() | ||
| ) | ||
|
|
||
| assert actual == expected | ||
|
|
There was a problem hiding this comment.
just as a sanity check, could we also make sure it works with scalar values
select url_download("https://...") from df;
CodSpeed Performance ReportMerging #3690 will improve performances by 80.78%Comparing Summary
Benchmarks breakdown
|
RCHowell
deleted the
rchowell/df-109-add-missing-url_-functions-to-sql
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3575
This change is a bit larger because I had to change how url_download and url_upload handled the parsing of keyword arguments to be more like image functions. I also moved some re-usable SQL argument parsing logic to a functions::args module.
I've left some notes/TODOs regarding input validation and handling of named parameters, but addressing these is outside the scope of this PR.