Add distribution support to gradle-plugin #297
Conversation
chromy
force-pushed
the
chromy/2024-10-22-distro-gradle
branch
4 times, most recently
from
b4a7497 to
a9ea833
Compare
chromy
force-pushed
the
chromy/2024-10-22-distro-gradle
branch
2 times, most recently
from
5faa01b to
c82c886
Compare
chromy
force-pushed
the
chromy/2024-10-22-distro-gradle
branch
from
c82c886 to
566216e
Compare
chromy
changed the title
| apiKey.set(System.getenv("DISTRIBUTION_API_KEY")) | ||
|
|
||
| // Optional, defaults to 'release' | ||
| tag.set("release") |
There was a problem hiding this comment.
Tag doesn't seem to be relevant currently - I'd suggest removing it until we have an upload-related task around distro to avoid confusion
There was a problem hiding this comment.
Tag is used to define the release 'channel' (when the SDK checks for an update we send the tag and only consider builds a with matching tag). Possibly we should have a distribution upload task but I was worried that just makes it more confusing.
|
|
||
| /** | ||
| * The key used to authenticate downloads for future updates. | ||
| * Emerge recommends setting this as an environment variable. |
There was a problem hiding this comment.
so, my thought on simplifying this API would be that we should remove this API and instead just check the environment variable DISTRIBUTION_API_KEY.
If a customer needs a way to set this via the extension, then we should add it.
| @@ -294,6 +295,17 @@ class EmergePlugin : Plugin<Project> { | |||
| ) | |||
| addItem("tag (optional): ${extension.reaperOptions.tag.orEmpty()}", reaperHeading) | |||
|
|
|||
| val distributionHeading = addHeading("distribution") | |||
There was a problem hiding this comment.
this might need rebasing, i moved this logExtension function to a new task in a recent change.
| /** | ||
| * The list of build variants Distribution is enabled for. | ||
| */ | ||
| abstract val enabledVariants: ListProperty<String> |
There was a problem hiding this comment.
I’m just thinking about this from a perspective of simplifying this API, what would be the downside to enabling distribution for all variants? Can we remove this API from the initial release?
No description provided.