-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned and extended function that extracts datetimes from paths #2181
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2181 +/- ##
==========================================
+ Coverage 93.19% 93.22% +0.02%
==========================================
Files 238 238
Lines 12826 12836 +10
==========================================
+ Hits 11953 11966 +13
+ Misses 873 870 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @schlunma! Just one minor question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
biutiful, fellas 🍻
Description
This PR
local.py
by removing the duplicated code in the function_get_start_end_year
and uses_get_start_end_date
instead.The first is used in CMIP3 data, the latter in native ERA5 data in GRIB format. This speeds up many recipes by quite some time, since only the files that are actually relevant for the user are processed.
Note that I did not change any existing test case, so this should be fully backwards-compatible.
Closes #2180
Addresses parts of #1991
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: