[ADXT-815] [e2e] filepath.Join should be agnostic of the runner OS #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… kfairise/fix-filepath-join-windows
clarkb7
approved these changes
Jan 10, 2025
chouetz
approved these changes
Jan 13, 2025
| @@ -121,7 +125,7 @@ func (fs unixOSCommand) copyLocalFile(runner *LocalRunner, name string, src, dst | |||
|
|
|||
| func (fs unixOSCommand) copyRemoteFile(runner *RemoteRunner, name string, src, dst pulumi.StringInput, opts ...pulumi.ResourceOption) (pulumi.Resource, error) { | |||
| tempRemotePath := src.ToStringOutput().ApplyT(func(path string) string { | |||
| return filepath.Join(runner.OsCommand().GetTemporaryDirectory(), filepath.Base(path)) | |||
There was a problem hiding this comment.
Is it the only occurrence we needed to change?
There was a problem hiding this comment.
Yep in our code. There are other occurences but in KMT specific which I think there is no chance it can be ran from a Windows laptop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some operations currently uses the runner OS information to determine the separator. It does not make sense as the commands are excuted on the target OS. This PR updates that so the commands are executed depending on the target OS
Which scenarios this will impact?
Motivation
Additional Notes