feat: Bump ibc-go version to 9.0.2 #2095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulikthebird
requested review from
pinosu and
chipshort
and removed request for
pinosu
kulikthebird
force-pushed
the
tkulik/bump_ibc_v9
branch
from
522dbfc to
bd3b37b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2095 +/- ##
==========================================
+ Coverage 42.99% 43.02% +0.03%
==========================================
Files 85 85
Lines 11601 11611 +10
==========================================
+ Hits 4988 4996 +8
- Misses 6166 6169 +3
+ Partials 447 446 -1
|
chipshort
reviewed
Jan 17, 2025
| tmLightClientModule := ibctm.NewLightClientModule(appCodec, storeProvider) | ||
| clientKeeper.AddRoute(ibctm.ModuleName, &tmLightClientModule) | ||
|
|
||
| smLightClientModule := solomachine.NewLightClientModule(appCodec, storeProvider) |
There was a problem hiding this comment.
Do we really want the solo machine here? The IBC integration docs only add the 07-tendermint light client
| @@ -115,7 +114,6 @@ func NewRootCmd() *cobra.Command { | |||
| // add keyring to autocli opts | |||
| autoCliOpts := tempApp.AutoCliOpts() | |||
| initClientCtx, _ = config.ReadFromClientConfig(initClientCtx) | |||
| autoCliOpts.Keyring, _ = keyring.NewAutoCLIKeyring(initClientCtx.Keyring) | |||
There was a problem hiding this comment.
Is this related to the ibc-go update?
| @@ -43,12 +43,12 @@ func TestIBCCallbacks(t *testing.T) { | |||
| path := wasmibctesting.NewPath(chainA, chainB) | |||
| path.EndpointA.ChannelConfig = &ibctesting.ChannelConfig{ | |||
| PortID: ibctransfertypes.PortID, | |||
| Version: string(marshaler.MustMarshalJSON(&ibcfee.Metadata{FeeVersion: ibcfee.Version, AppVersion: ibctransfertypes.Version})), | |||
| Version: string(marshaler.MustMarshalJSON(&ibcfee.Metadata{FeeVersion: ibcfee.Version, AppVersion: ibctransfertypes.V2})), | |||
There was a problem hiding this comment.
Ah, nice. So, v9 enables transferv2 by default now?
| @@ -299,6 +300,7 @@ func (i IBCHandler) OnRecvPacket( | |||
| // OnAcknowledgementPacket implements the IBCModule interface | |||
| func (i IBCHandler) OnAcknowledgementPacket( | |||
| ctx sdk.Context, | |||
| channelVersion string, | |||
There was a problem hiding this comment.
Do we need to expose this to the contract? (Maybe not in here, but in the long term?)
Comment on lines
+431
to
+437
| func (chain *TestChain) GetLatestHeight(clientState exported.ClientState) clienttypes.Height { | ||
| tmClientState, ok := clientState.(*ibctm.ClientState) | ||
| if !ok { | ||
| panic("invalid client state type") | ||
| } | ||
| return tmClientState.LatestHeight | ||
| } |
There was a problem hiding this comment.
Why is this a method on the TestChain type? It doesn't use the chain at all. Couldn't this be a freestanding function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.