Request new match #74
Conversation
|
this pr is kinda critical as it probably breaks all other open and future prs due to massive merge conflicts |
I agree, I think we should first merge #71 and then merge this one |
|
Can we also merge this directly into main? |
Yes we can. But what happened to the concept of the pre-production branch? |
As long as this branch is a branch of the development branch it is fine, we just need to remember to merge main into development before starting something new |
commands/match/match-command.ts
Outdated
| import findMatchingUser from '../../functions/findMatchingUser'; | ||
| import conversationStarter from '../../functions/conversationStarter'; | ||
|
|
||
| export const sendQuestion = async (interaction: any) => { |
There was a problem hiding this comment.
Why are we declaring the sendQuestion function and not just importing the old one?
commands/match/match-command.ts
Outdated
| sendQuestion(interaction); | ||
| } else { | ||
| await interaction.reply({ | ||
| content: 'Bitte beantworte den Meinungstest vollständig, bevor du mit Anderen gematcht werden kannst! Bitte nutze dazu den Befehl `/test`.', |
There was a problem hiding this comment.
Could we maybe automatically trigger the test command if the user has not finished the test?
|
Also could you think of a way where we could put a button that starts the /match command to make it easier for users to find this feature? |
|
please don't use feature branches to completely re-structure the entire codebase in the future |
Fix #42