Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine filtering logic for [GeneratedBindableCustomProperty] analyzers #1019

Merged
merged 3 commits into from
Dec 7, 2024
Merged

Refine filtering logic for [GeneratedBindableCustomProperty] analyzers #1019

merged 3 commits into from
Dec 7, 2024

Conversation

Sergio0694
Copy link
Member

Contributes to #1018

This PR refines some analyzers to take into account parameters to [GeneratedBindableCustomProperty].

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Dec 7, 2024
@Sergio0694 Sergio0694 changed the title Dev/generated bcp constructors Refine filtering logic for [GeneratedBindableCustomProperty] analyzers Dec 7, 2024
@Sergio0694 Sergio0694 merged commit 857de64 into main Dec 7, 2024
3 checks passed
@Sergio0694 Sergio0694 deleted the dev/generated-bcp-constructors branch December 7, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analyzer 👓 A new analyzer being implemented or updated improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sergio0694