Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to "maven artifacts" and result of "goJF" #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

in-fke
Copy link
Contributor

@in-fke in-fke commented Jan 25, 2022

  • Renamed Maven artifactId to better match the gradle equivalent.
  • Commented out the signing via maven-gpg-plugin (pom.xml)
  • Also checked in the results of "./gradlew goJF" (Java Formatting) (regular gradle build would fail due to formatting errors)

@TVolden
Copy link
Member

TVolden commented Feb 26, 2022

Hi @in-fke,

First of all thanks for your contribution.
I haven't accepted this one yet, as I don't know what the consequences of changing an artifacts name.
Would people who use the lib via maven have to refer to a different artifact in their POM files?

Sincerely,
Thomas

@in-fke
Copy link
Contributor Author

in-fke commented Mar 8, 2022

Would people who use the lib via maven have to refer to a different artifact in their POM files?

Yes, if they want to upgrade to a newer version.
I you change things you will not break things for others automatically since their are still referencing the old identifier.
You should raise the version and adjust the artifactId at the same time.
See how the artifacts are currently available:
https://search.maven.org/search?q=g:eu.chargetime.ocpp
e.g. https://search.maven.org/artifact/eu.chargetime.ocpp/v1_6/1.0.1/jar
Changing it in your pom.xml / gradle the people who use it need to adjust accordingly.
<grouId>:<artifactId>:<version>
is a distinct artifact identifier globally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Your Maven Artifact Ids are "common" and "v1_6" - should be more distinct
2 participants