Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiple filters in filterobjects_stringmatch #266

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

ErinWeisbart
Copy link
Member

No description provided.

@bethac07
Copy link
Member

Cool! The one thing I wanted to check on - should the kind of check you want to do be part of the settings group, aka should we support multiple kinds of check in the same module? I can certainly see the case for "we don't want AGCTCT as an exact match, OR AAA OR CCC as partial matches". Fine to pull as is and do that later also just food for thought.

@ErinWeisbart
Copy link
Member Author

I thought about it, and we certainly can, but I decided to do it this way for now because 1) it served the purpose I need right now 2) worst case scenario if someone needs all sorts of filters, they still would only need 4 copies of the module as they are only 4 kinds of filtering and I'm used to having many, many copies of the same module in a pipeline so a max of 4 seemed downright reasonable

@bethac07 bethac07 merged commit 677fb7a into master Dec 13, 2024
0 of 6 checks passed
@bethac07 bethac07 deleted the multimatch branch December 13, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants