Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: site curator only relevant for curateable path/method #71

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

daisieh
Copy link
Member

@daisieh daisieh commented Oct 4, 2024

I noticed a failure in the integration tests: I need to separate the readable path/method combos from the curateable ones, and site curators are only allowed to curate curateable ones, regardless of program. This is how we can allow site curator to create non-existent programs without allowing them to read programs they're not authorized for. (Is this actually the behavior we want?)

@daisieh daisieh requested a review from kcranston October 4, 2024 18:48
@mshadbolt
Copy link
Contributor

I think given a site_curator can modify program authorizations, it wouldn't make sense for them to not be able to ingest/delete programs that they didn't specifically create. Therefore I think it makes sense for site curators to be able to read/ingest/delete any program at a site.

For testing purposes, I don't think the test users should be given any default site or program roles (apart from the need to set up a site admin). This will allow us to properly test the apis for setting up the roles during the tests, instead of having defaults and we assume the functionality is in place.

@kcranston
Copy link
Member

Agree that site curators should be able to read / write all programs. Thanks for the change.

@daisieh daisieh merged commit 820a02f into develop Oct 4, 2024
1 check passed
@daisieh daisieh deleted the hotfix/site-curator-2 branch October 4, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants