This repository has been archived by the owner on Jun 13, 2020. It is now read-only.
Create tables and initialize with dummy data if required #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "PIRAT_WEBAPP_ENVIRONMENT", | ||
|
|
||
| "PIRAT_INIT_DB_TABLES_IF_NOT_EXIST", | ||
| "PIRAT_INIT_DUMMY_DATA_IF_NOT_EXIST" |
There was a problem hiding this comment.
The variables should be optional with false being the default. Please also don't forget to edit the README.
There was a problem hiding this comment.
I do not see a disadvantage here to let them non optional. At least the developer or the server must initialize the fields with something. It's not much work...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
init.sqlto load the commands to create tables and to define keys.Use
init_dummy_offers.jsonto load dummy data. init_dummy_offers.json contains so calledOfferContextentries. AnOfferContexthas all entities that are used when an offer normally is made using the API. I will add some more examples if we agree on the way it is currently implemented.Inserting other
init_dummy_*.jsonto the db is not implemented (region_subscription, demands). This should be done in a further branch.