Fix PlayerUsageUsage validation for string inputs and hireDate null value handling for coaches #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #13 and #15
Problem
The
PlayerUsageUsage
class was failing to validate inputs when the API returned numeric values as strings.Solution
Added a validator to convert string inputs to floats, allowing the model to handle both string and numeric inputs. This makes the
PlayerUsageUsage
class more robust and able to handle different input formats without breaking.Changes
@validator
decorator to convert string inputs to floatsTesting
Tested with test files in ./test folder
Backwards Compatibility
This change maintains backwards compatibility as it will still work with numeric inputs.
Fix hireDate parsing in Coach model
Changes
Modified the hire_date field in the Coach model to be an optional string.
File changed: models/coach.py
This PR addresses the issue with parsing the hireDate field in the Coach model. It changes the field to an optional string to avoid validation errors with null or improperly formatted dates.
from typing import Optional
from pydantic import BaseModel, Field
Testing
Tested with test files in ./test folder