Skip to content

Commit

Permalink
Merge pull request #820 from CEED/jeremy/warn-occa
Browse files Browse the repository at this point in the history
Add OCCA backend warning
  • Loading branch information
jeremylt authored Oct 1, 2021
2 parents 3075221 + 19772aa commit aae8ce3
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 13 deletions.
3 changes: 2 additions & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ noether-rocm:
- echo "-------------- OCCA ----------------" && make -C $OCCA_DIR info
# libCEED
- make configure HIP_DIR=/opt/rocm OPT='-O -march=native -ffp-contract=fast'
- BACKENDS_CPU=$(make info-backends-all | grep -o '/cpu[^ ]*') && BACKENDS_GPU=$(make info-backends | grep -o '/gpu[^ ]*')
# Note: OCCA backends currently disabled in CI
- BACKENDS_CPU=$(OCCA_DIR= make info-backends-all | grep -o '/cpu[^ ]*') && BACKENDS_GPU=$(OCCA_DIR= make info-backends | grep -o '/gpu[^ ]*')
- echo "-------------- libCEED -------------" && make info
- echo "-------------- BACKENDS_CPU---------" && echo $BACKENDS_CPU
- echo "-------------- BACKENDS_GPU---------" && echo $BACKENDS_GPU
Expand Down
3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -637,9 +637,6 @@ install : $(libceed) $(OBJDIR)/ceed.pc
$(INSTALL_DATA) $(OBJDIR)/ceed.pc "$(DESTDIR)$(pkgconfigdir)/"
$(INSTALL_DATA) include/ceed.h "$(DESTDIR)$(includedir)/"
$(INSTALL_DATA) include/ceedf.h "$(DESTDIR)$(includedir)/"
$(INSTALL_DATA) include/ceed-backend.h "$(DESTDIR)$(includedir)/"
$(INSTALL_DATA) include/ceed-hash.h "$(DESTDIR)$(includedir)/"
$(INSTALL_DATA) include/ceed-khash.h "$(DESTDIR)$(includedir)/"

.PHONY : all cln clean doxygen doc lib install par print test tst prove prv prove-all junit examples style style-c style-py tidy info info-backends info-backends-all

Expand Down
2 changes: 2 additions & 0 deletions backends/occa/ceed-occa.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
// software, applications, hardware, advanced system engineering and early
// testbed platforms, in support of the nation's exascale computing imperative.

#warning "libCEED OCCA backend is experimental; for best performance, use device native backends"

#include <map>
#include <vector>
#include <occa.hpp>
Expand Down
2 changes: 2 additions & 0 deletions doc/sphinx/source/releasenotes.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ for each release of libCEED.
- Clarify and document conditions where `CeedQFunction` and `CeedOperator` become immutable and no further fields or suboperators can be added.
- Add {c:func} `CeedOperatorLinearAssembleQFunctionBuildOrUpdate` to reduce object creation overhead in assembly of CeedOperator preconditioning ingredients.
- Promote {c:func} `CeedOperatorCheckReady`to the public API to facilitate interactive interfaces.
- Warning added when compiling OCCA backend to alert users that this backend is experimental.
- `ceed-backend.h`, `ceed-hash.h`, and `ceed-khash.h` removed. Users should use `ceed/backend.h`, `ceed/hash.h`, and `ceed/khash.h`.

### New features

Expand Down
3 changes: 0 additions & 3 deletions include/ceed-backend.h

This file was deleted.

3 changes: 0 additions & 3 deletions include/ceed-hash.h

This file was deleted.

3 changes: 0 additions & 3 deletions include/ceed-khash.h

This file was deleted.

0 comments on commit aae8ce3

Please sign in to comment.