Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding urban development to the trunk CABLE urban branch #499

Open
wants to merge 6 commits into
base: CABLE-Urban
Choose a base branch
from

Conversation

jiachenluMet
Copy link

@jiachenluMet jiachenluMet commented Nov 29, 2024

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

Please include a brief summary of the change and list the issues that are fixed.
Please also include relevant motivation and context.

You can link issues by using a supported keyword in the pull request's description or in a commit message:

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix
  • New or updated documentation

Checklist

  • The new content is accessible and located in the appropriate section.
  • I have checked that links are valid and point to the intended content.
  • I have checked my code/text and corrected any misspellings

Please add a reviewer when ready for review.

@ccarouge
Copy link
Member

ccarouge commented Dec 4, 2024

@jiachenluMet we don't want or need a PR to bring your work from your fork into the CABLE repository. If you want I can bring the work over and then you can work directly within the CABLE repository and not your fork. Is that ok with you?

I would also like the branch "CABLE-Urban" to be renamed. Because the urban work is way too big to bring in one go. What is the first aspect you are working on? Is it still about bringing urban relevant surface parameters?
Actually could you start by opening an issue about what you are doing and we can see there what the first step is about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants