322 use netcdf inputs for bios met #458
Open
+467
−968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Involves some restructuring in the SPATIOTEMPORALDATASET type to handle cases where given variables are not given. Work was ported from a working branch that got a bit messy during testing.
Now get bitwise identical results to the POP_TRENDY branch when running the BIOS configuration (with the correction for previous day temperature in the BIOS code)
ccarouge
requested changes
Nov 8, 2024
Includes some improved and corrected commentary, removal of magic numbers and made some variable names more self-descriptive. Clarifying date handling workflow to come.
Existing code is commented out as I need to re-run the BIOS test to ensure correctness before removing it entirely.
ccarouge
requested changes
Nov 18, 2024
Add checks that nearby temporal searches aren't looking too far, minor errors in inequalities and mistake in next day variable.
ccarouge
reviewed
Nov 26, 2024
|
@Whyborn @ccarouge Apologies I've just returned to trawling through github notifications and realised I hadn't looked at this from last month. Could you go through and let me know if there are any unresolved questions from the thread? In the main I'm less worried about maintaining reproducibility that I am about getting the science correct (but realise that's likely not how the NRI want to work) |
|
I'm in the process of merging into POP_TRENDY, just need to test after addressing the merge conflicts. I picked up a mistake I'd made in a prior PR while doing this, so got sidetracked fixing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CABLE
Thank you for submitting a pull request to the CABLE Project.
Description
This PR routes the BIOS inputs through the new input routines developed for the CRU/TRENDY experiments. It involves some minor restructuring of the existing routines to handle instances where an amount less than the full set of possible variable datasets are passed via the namelist. The
cable_user%RunType='bios'still exists for the ancillaries. This should operate completely independently of the ancillary work.The outputs of the 9 point ACT test are bitwise equivalent with 2 caveats:
WG%TempMaxDayPrevis corrected in the original BIOS routines (handling at first day of run was incorrect).I am doing some longer term work in neatening up and improving the met routines to generalise them for more arbitrary sets of input variables, but this serves as an acceptable interim that should work seamlessly with Abhaas' work with the ancillaries.
Part of #(322)
Type of change
Enhancement
Checklist