Promote or_default idiom for checking file names
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`unwrap_or_default()` feels somewhat easier to read than `.map` and `.unwrap_or_false`. It doesn't make a big difference here, but we can use an opportunity to teach folks that this idiom exists. Note that both version work incorrectly for non-utf8 file names, which is unfortunate, but isn't something we can do anything about in the example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how you'd feel about it, but decided to PR just in case!
unwrap_or_default()feels somewhat easier to read than.mapand.unwrap_or_false. It doesn't make a big difference here, but we canuse an opportunity to teach folks that this idiom exists.
Note that both version work incorrectly for non-utf8 file names, which
is unfortunate, but isn't something we can do anything about in the
example.