container: add container image version #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
requested changes
Dec 16, 2024
scripts/dockerdev.sh
Outdated
| @@ -38,13 +35,15 @@ dockerdev () { | |||
| fi | |||
|
|
|||
| # If already running, enter the container. | |||
| if $RUNTIME ps | grep -q $container_name; then | |||
| if $RUNTIME ps | grep -q $image_name:$CONTAINER_VERSION; then | |||
There was a problem hiding this comment.
this seems wrong docker ps shows the running containers, which are named with the container name, not the image name. If I have the same image running under a different name, I don't want dockerdev to use that.
There was a problem hiding this comment.
Good point, added a second filter 👍
scripts/dockerdev.sh
Outdated
| echo "No bitbox-wallet docker image found! Maybe you need to run 'make dockerinit'?" >&2 | ||
| exit 1 | ||
| fi | ||
| local image_name=bitbox-wallet-app |
There was a problem hiding this comment.
should be shiftcrypto/bitbox-wallet-app, shiftcrypto/ is part of the image name.
This will allow to checkout older commits and run `make dockerdev` without worrying if the container image version changed.
Beerosagos
force-pushed
the
container-version
branch
from
5be2b03 to
ace02fe
Compare
|
@benma updated, PTAL 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to checkout older commits and run
make dockerdevwithout worrying if the container image version changed.