Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Diacritical Mark, and fix stroke being crop #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Support for Diacritical Mark, and fix stroke being crop #341

wants to merge 1 commit into from

Conversation

samx81
Copy link

@samx81 samx81 commented May 22, 2024

  • feat: combines diacritical mark with its previous character to proper draw diacritical chars
  • fix: wider stroke can be correctly draw without cutting off

Before:

Text: 佇咧麵擔仔的kha̋ng-páng頂懸

wrong_dia

wrong and ugly cut off under "麵擔仔的"
wrong_stroke

After:

correct_dia

- feat: combines diacritical mark with its previous character to prop…
cf48a7b 
…er draw diacritical chars

- fix: wider stroke can be correctly draw without cutting off
@samx81 samx81 mentioned this pull request May 22, 2024
Open
@samx81 samx81 changed the title Add Support for Diacritical Mark, and fix stroke being cut off Add Support for Diacritical Mark, and fix stroke being crop May 23, 2024
@samx81
Copy link
Author

samx81 commented May 23, 2024 •
edited
Loading

I realize that word_split options can solve diacritical mark problem too, however stroke cropping problem can still be solved by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samx81