Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(prettier): fixed endOfLine param & exclusions in css packages #61

Merged
merged 1 commit into from
Jan 12, 2024
Merged

build(prettier): fixed endOfLine param & exclusions in css packages #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/prettier.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
endOfLine: "auto",
};
6 changes: 3 additions & 3 deletions packages/css/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"eslint:fix": "eslint src --ext js,jsx,ts,tsx --fix",
"stylelint": "stylelint \"src/**/*.{scss,css}\"",
"stylelint:fix": "stylelint \"src/**/*.{scss,css}\" --fix",
"prettier": "prettier \"src/**/*.!(js|jsx|ts|tsx|scss|css)\" --check",
"prettier:fix": "prettier \"src/**/*.!(js|jsx|ts|tsx|scss|css)\" --write",
"prettier": "prettier \"src/**/*\" --check",
"prettier:fix": "prettier \"src/**/*\" --write",
"tsc": "tsc --noEmit"
},
"devDependencies": {
Expand Down Expand Up @@ -85,7 +85,7 @@
"*.(js|jsx|ts|tsx)": "eslint --fix",
"*.(ts|tsx)": "tsc-files --noEmit",
"*.(scss|css)": "stylelint --fix",
"*.!(js|jsx|ts|tsx|scss|css)": "prettier --write"
"*.mdx": "prettier --write"
},
"volta": {
"node": "20.10.0",
Expand Down
1 change: 1 addition & 0 deletions packages/css/prettier.config.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.prettierrc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pourquoi ce nom en particulier ? Y a tout cela qui sont possibles : https://prettier.io/docs/en/configuration.html
Y a une limitation particuliere pour les autres ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est juste moi j'ai mis .eslintrc dans les packages donc juste pour la cohérence après ca ne me dérange pas plus que ca

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module.exports = require("../../config/prettier.config");
2 changes: 1 addition & 1 deletion packages/react/package.json
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu n'as pas update les npm script prettier comme sur le package css ? est normale ?

Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"lint-staged": {
"*.(js|jsx|ts|tsx)": "eslint --fix",
"*.(ts|tsx)": "tsc-files --noEmit",
"*.!(js|jsx|ts|tsx)": "prettier --write"
"*.mdx": "prettier --write"
},
"volta": {
"node": "20.10.0",
Expand Down
1 change: 1 addition & 0 deletions packages/react/prettier.config.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.prettierrc

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module.exports = require("../../config/prettier.config");
6 changes: 3 additions & 3 deletions packages/react/src/agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ export { ButtonAgent as Button } from "./Button/Button.agent";
export { Text, TextInput } from "./Form/InputText";
export {
Field,
FieldInput,
MessageTypes,
FieldError,
FormClassManager,
FieldForm,
FieldInput,
FormClassManager,
HelpMessage,
InputList,
MessageTypes,
getComponentClassName,
} from "./Form/core";