Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goals First: Add goals in the launchpad step calypso_signup_step_start event #98448

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

vykes-mac
Copy link
Contributor

Closes #98121

Proposed Changes

  • Add goals in the launchpad step calypso_signup_step_start event
  • Skip goals being cleared when resetting onboarding store in site-setup since we need them at the launchpad step

Why are these changes being made?

Testing Instructions

  • Go to /setup/onboarding ensure you are in the goals-first flow
  • Select a goal and continue to the launchpad
  • Verify calypso_signup_step_start has the goals and is_goals_first props.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@vykes-mac vykes-mac self-assigned this Jan 16, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~7 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +70 B  (+0.0%)       +7 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~167 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
build-flow            +537 B  (+0.0%)     +155 B  (+0.0%)
subscribers            +70 B  (+0.0%)       +8 B  (+0.0%)
staging-site           +70 B  (+0.0%)       +8 B  (+0.0%)
site-tools             +70 B  (+0.0%)       +8 B  (+0.0%)
site-settings          +70 B  (+0.0%)       +8 B  (+0.0%)
settings               +70 B  (+0.0%)       +8 B  (+0.0%)
home                   +70 B  (+0.0%)       +8 B  (+0.0%)
checkout               +70 B  (+0.0%)       +8 B  (+0.0%)
site-setup-wg          +12 B  (+0.0%)       +4 B  (+0.0%)
site-setup-flow        +12 B  (+0.0%)       +4 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~8 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected        +70 B  (+0.0%)       +8 B  (+0.0%)
async-load-signup-steps-plans                          +70 B  (+0.0%)       +8 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@vykes-mac vykes-mac added Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracks Event: calypso_signup_step_start event on step=launchpad add props goals and is_goals_first
2 participants