-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove style variation upgrade badge tooltip #98429
base: trunk
Are you sure you want to change the base?
Conversation
The default style upgrade tooltip was removed, so we should also remove it for the style variations to be consistent.
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~505 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~366 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Should |
@rcrdortiz - Goal tracking was added for `global-styles/on-personal-plan' in #96053, and this PR will remove that tracking from being hit since the component will not be in use anymore. Is that an issue? Does that tracking need to be added somewhere else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it works as described! thanks for the update!
Related to #95471 and closes #98324
Proposed Changes
Remove style variation upgrade badge tooltip
Why are these changes being made?
The default style upgrade tooltip was removed, so we should also remove it for the style variations to be consistent.
Testing Instructions
Pre-merge Checklist