Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove style variation upgrade badge tooltip #98429

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

jeryj
Copy link
Contributor

@jeryj jeryj commented Jan 15, 2025

Related to #95471 and closes #98324

Proposed Changes

Remove style variation upgrade badge tooltip

Why are these changes being made?

The default style upgrade tooltip was removed, so we should also remove it for the style variations to be consistent.

Testing Instructions

Before After
image image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

The default style upgrade tooltip was removed, so we should also remove it for the style variations to be consistent.
@jeryj jeryj self-assigned this Jan 15, 2025
@jeryj jeryj requested review from richtabor and fditrapani January 15, 2025 17:18
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 15, 2025
@jeryj jeryj requested a review from mikachan January 15, 2025 17:18
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/upgrade-style-variation-tooltip on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 15, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~505 bytes removed 📉 [gzipped])

name    parsed_size           gzip_size
themes      -1361 B  (-0.1%)     -366 B  (-0.1%)
theme        -783 B  (-0.1%)     -139 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~366 bytes removed 📉 [gzipped])

name                                     parsed_size           gzip_size
async-load-signup-steps-theme-selection      -1361 B  (-0.4%)     -366 B  (-0.3%)
async-load-design-blocks                     -1361 B  (-0.1%)     -366 B  (-0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jeryj
Copy link
Contributor Author

jeryj commented Jan 15, 2025

Should /theme-tier-style-variation-badge get removed? If this PR is merged, that file won't be accessed by anything.

@jeryj
Copy link
Contributor Author

jeryj commented Jan 15, 2025

@rcrdortiz - Goal tracking was added for `global-styles/on-personal-plan' in #96053, and this PR will remove that tracking from being hit since the component will not be in use anymore. Is that an issue? Does that tracking need to be added somewhere else?

Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works as described! thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LiTS & LoTS not showing the upgrade tooltip with default style variation
3 participants