Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Settings: Display actual password status #98418

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

zaguiini
Copy link
Contributor

@zaguiini zaguiini commented Jan 15, 2025

Closes #62978.

Proposed Changes

Check the is_passwordless_user field from settings to determine whether or not a password is set in the account instead of hardcoding the message.

@fditrapani @nuriapenya could you please check if the copy here makes sense or we want something else? I was wondering if we could display something related to their auth method. Example: "You do not have a password set because you're registered through Google" or "You do not have a password set because you're logging in through magic links."

I don't know that we can identify which mechanisms they're picking, though. So maybe a generic message could work better.

Testing Instructions

Proxy yourself to your sandbox and apply this branch to it: 170128-ghe-Automattic/wpcom.

User and password

Enter /me/security using your A8C account or any account created with the user and password method and verify that you see the "password set" message in the security checklist:

image

Passwordless mode

Create or log in with a passwordless account and enter /me/security. You should see the "password not set" message:

image

Upon clicking the checklist item and defining a password, subsequent /me/security visits should show the "password set" message.

Social login

Create or log in with a social account (Google, Apple, GitHub) and enter /me/security. You should see the "password not set" message:

image

Upon clicking the checklist item and defining a password, subsequent /me/security visits should show the "password set" message.

@zaguiini zaguiini self-assigned this Jan 15, 2025
@zaguiini zaguiini added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 15, 2025
@zaguiini zaguiini requested a review from a team January 15, 2025 14:29
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 15, 2025
@zaguiini zaguiini requested a review from fditrapani January 15, 2025 14:29
@zaguiini zaguiini marked this pull request as ready for review January 15, 2025 14:29
@matticbot
Copy link
Contributor

matticbot commented Jan 15, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~67 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
security       +323 B  (+0.0%)      +67 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/display-actual-password-status-in-me-security on your sandbox.

@fditrapani
Copy link
Contributor

Thanks for the ping @zaguiini. The word configured sounds very technical. We should replace it with something more human like "set":

  • You have a password set but you can change it any time.
  • You don't have a password set.

@a8ci18n
Copy link

a8ci18n commented Jan 15, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17195170

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @zaguiini for including a screenshot in the description! This is really helpful for our translators.

@zaguiini
Copy link
Contributor Author

Thanks @fditrapani 🚀

Copy link
Contributor

@vykes-mac vykes-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Password-less account is described as having a password set
5 participants