-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security Settings: Display actual password status #98418
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~67 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Thanks for the ping @zaguiini. The word configured sounds very technical. We should replace it with something more human like "set":
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17195170 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @zaguiini for including a screenshot in the description! This is really helpful for our translators. |
Thanks @fditrapani 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #62978.
Proposed Changes
Check the
is_passwordless_user
field from settings to determine whether or not a password is set in the account instead of hardcoding the message.@fditrapani @nuriapenya could you please check if the copy here makes sense or we want something else? I was wondering if we could display something related to their auth method. Example: "You do not have a password set because you're registered through Google" or "You do not have a password set because you're logging in through magic links."
I don't know that we can identify which mechanisms they're picking, though. So maybe a generic message could work better.
Testing Instructions
Proxy yourself to your sandbox and apply this branch to it: 170128-ghe-Automattic/wpcom.
User and password
Enter
/me/security
using your A8C account or any account created with the user and password method and verify that you see the "password set" message in the security checklist:Passwordless mode
Create or log in with a passwordless account and enter
/me/security
. You should see the "password not set" message:Upon clicking the checklist item and defining a password, subsequent
/me/security
visits should show the "password set" message.Social login
Create or log in with a social account (Google, Apple, GitHub) and enter
/me/security
. You should see the "password not set" message:Upon clicking the checklist item and defining a password, subsequent
/me/security
visits should show the "password set" message.