Fix broken miller-rabin primality test #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only return early if we did not break due to the (n-1) case. Otherwise, we need to 'goto' the outer loop and repeat
|
Looks great and works. I will merge it in now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only return early if we did not break due to the (n-1) case. Otherwise, we need to 'goto' the outer loop and repeat. See the pseudocode: https://en.wikipedia.org/wiki/Miller%E2%80%93Rabin_primality_test. Note the
continue WitnessLoopwhich was previously just abreakin this code.Added some tests to verify the functionality.
This fixes the issues mentioned in issue #1 .
Some of the existing tests seem to fail/run forever(Verification::is_very_smooth_number, factorization) on master; however, I verified that the new tests pass.