Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed useLedger and login toggle #1371

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Aug 11, 2024

Pull Request Summary

  • fix: removed useLedger and login toggle

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Fixes

=Before=
image

=After=

image

@impelcrypto impelcrypto requested a review from bobo-k2 August 11, 2024 07:42
Copy link

Visit the preview URL for this PR (updated for commit a691e9d):

https://astar-apps--pr1371-fix-remove-ledger-to-a2kropdr.web.app

(expires Sun, 18 Aug 2024 07:51:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@bobo-k2
Copy link
Contributor

bobo-k2 commented Aug 11, 2024

I see this in state.ts isLedger: localStorage.getItem(LOCAL_STORAGE.IS_LEDGER) === 'true', and usage of isLedger across the codebase. You don't need to clean up now, but please create a ticket so we don't forget about it.

@impelcrypto impelcrypto merged commit 7412b67 into fix/ledger Aug 11, 2024
6 checks passed
@impelcrypto impelcrypto deleted the fix/remove-ledger-toggle-2 branch August 11, 2024 07:55
bobo-k2 added a commit that referenced this pull request Aug 11, 2024
* disable celer bridge (#1353)

* disable cbridge

* fix statement shorter

* disable celer bridge icon too (#1354)

* Fix usePrice hooks (#1355)

* fix usePrice issue

* refactor, just using immediate is enough

* only enable immediate for h160 wallet (#1356)

* Add metadata hash and uplift to polkadot 12.0.1

* Added // @ts-nocheck to ignore some typing errors for now

* More // @ts-nocheck

* WithSignedTransaction

* Remove hash

* $api removed

* fix: removed useLedger and login toggle (#1371)

---------

Co-authored-by: Taegeon Alan Go <[email protected]>
Co-authored-by: Roy <[email protected]>
@impelcrypto
Copy link
Member Author

#1371 (comment)

I see, let's remove the previous ledger logic after the hotfix branch has been merged to main.

bobo-k2 added a commit that referenced this pull request Aug 16, 2024
* hotfix: enable xcm with Bifrost (#1361)

* Fix ledger on the portal (#1370)

* disable celer bridge (#1353)

* disable cbridge

* fix statement shorter

* disable celer bridge icon too (#1354)

* Fix usePrice hooks (#1355)

* fix usePrice issue

* refactor, just using immediate is enough

* only enable immediate for h160 wallet (#1356)

* Add metadata hash and uplift to polkadot 12.0.1

* Added // @ts-nocheck to ignore some typing errors for now

* More // @ts-nocheck

* WithSignedTransaction

* Remove hash

* $api removed

* fix: removed useLedger and login toggle (#1371)

---------

Co-authored-by: Taegeon Alan Go <[email protected]>
Co-authored-by: Roy <[email protected]>

* Add raw metadata to chain info (#1372)

* Add raw metadata to chain info

* Enable users to update metadata once more event if it is up to date

* Polkadot types errors fix (#1373)

* Fix polkadot types errors

* Be strict

* Polkasafe version update

---------

Co-authored-by: Roy <[email protected]>
Co-authored-by: Taegeon Alan Go <[email protected]>
impelcrypto added a commit that referenced this pull request Aug 21, 2024
* hotfix: enable xcm with Bifrost (#1361)

* Fix ledger on the portal (#1370)

* disable celer bridge (#1353)

* disable cbridge

* fix statement shorter

* disable celer bridge icon too (#1354)

* Fix usePrice hooks (#1355)

* fix usePrice issue

* refactor, just using immediate is enough

* only enable immediate for h160 wallet (#1356)

* Add metadata hash and uplift to polkadot 12.0.1

* Added // @ts-nocheck to ignore some typing errors for now

* More // @ts-nocheck

* WithSignedTransaction

* Remove hash

* $api removed

* fix: removed useLedger and login toggle (#1371)

---------

Co-authored-by: Taegeon Alan Go <[email protected]>
Co-authored-by: Roy <[email protected]>

* Add raw metadata to chain info (#1372)

* Add raw metadata to chain info

* Enable users to update metadata once more event if it is up to date

* Polkadot types errors fix (#1373)

* Fix polkadot types errors

* Be strict

* Polkasafe version update

* Fix for getting dApps (#1374)

---------

Co-authored-by: Roy <[email protected]>
Co-authored-by: Taegeon Alan Go <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants