-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PEN and XLM tokens to Astar portal #1348
Conversation
…N-token-to-Astar-Portal add PEN and XLM tokens to Astar portal
Thank you for the PR. Please send some test tokens to XLoLJBQoMPHMLXYhdFobSpH5GujRoUH8d1sUtaEtoBG7zaS |
Hi @b-yap ! Thank you for contribute on our portal, can you send me PEN and XLM for testing it? This is my Astar wallet address Thank you :) |
@bobo-k2 I have redeployed with a new vercel URL using the updated change: |
Hi @b-yap the new Vercel URL is asking me to authenticate, can you fix that? |
@bobo-k2 sorry for that. Updated: https://astar-apps-b-yap-bs-projects-fe8df2be.vercel.app/ |
When I started testing I had 3 xcPEN on Pendulum. After that I made two transactions from Astar I transfered 1 XLM.s from Astar to Pendulum and UI still showing 0 XML.s on Pendulum |
Moving this to draft, for now. We identified that the minimum transfer amounts we use so far are not large enough to cover the XCM transfer fees charged on Pendulum. We are currently discussing which values we should use and will update the PR accordingly. |
@bobo-k2 We have increased the minimum transferred amounts, thus gave you more XLMs and PENs to play with. |
Hi @b-yap and thank you for the update. Another problem arise in the meantime. I believe this happens because outdated polkadot.js version. Please merge |
…o sync-forked-repo
Sync forked repo
Hello @bobo-k2 , updated: 9b5c335 Also updated in vercel: https://astar-apps-b-yap-bs-projects-fe8df2be.vercel.app/ |
Hi @b-yap now I am having different error. Did you try Vercel deployment? |
Hi @bobo-k2 I redeployed again (doing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @b-yap |
@annatekl can you please get @impelcrypto the required tokens to test? |
sent |
@annatekl |
Shall i send 20 PEN to this address? |
@annatekl yes please |
sent @impelcrypto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When do I expect the assets to be added to the portal view? @impelcrypto |
@annatekl |
Pull Request Summary
Add support for PEN and XLM asset
This pull request makes the following changes:
Adds
Here are the extrinsic transactions for PEN:
https://astar.subscan.io/extrinsic/0xcacc02f33b8e6d74abb722504ae6f06e253d7d5db3891aac1f0074c8b6ca43dahttps://pendulum.subscan.io//extrinsic/0xaf7feb3e6b71a1f6c50964e9c44305360027678c0b9254341d6b0ccfd6b83553Test for minimum 0.1 PEN:https://pendulum.subscan.io//extrinsic/0xfbdd784f2eb845a952a0fefcf5ae76428b42bd4eeffd43936f00e38d768eaafbExtrinsic transactions of PEN token in order:
https://astar.subscan.io/extrinsic/0x6d4db503dc5ca31e33a0ac9a7770dca92594ec3dea2b65d9dfd78e32b792bdc2
Extrinsic transactions of XLM token in order:
Vercel URL:
astar-apps-b-yap-bs-projects-fe8df2be.vercel.apphttps://astar-apps-bs-projects-fe8df2be.vercel.app/