Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic QA #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

basic QA #36

wants to merge 3 commits into from

Conversation

dori-af
Copy link

@dori-af dori-af commented Oct 9, 2023

basic QA for Unreal

@dori-af
Copy link
Author

dori-af commented Oct 9, 2023

@liaz-af Please approve.

docs/API-1.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dori-af why do you have this file?

@@ -7,47 +7,28 @@ hidden: true
slug: ue-api
---

## Table of content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table of content need to stay for the Github users

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored the table


## Log Event

- In-app events help you track how loyal users discover your app, and attribute them to specific
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it's a bad idea, but why did you decide to remove this part?

- As a default, the start method is being called automatically once the app is being launch.

- If needed, this setting can be disabled in the Plugin settings, and the developer can call the start method under the blueprint. When doing so, the SDK will send a session on every background-foreground transition.
<img src="https://files.readme.io/6fe8c83-autoStartOff.png" width="400"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put back all the HTML style image references. They allow to determine the width, unlike markdown

Copy link
Author

@dori-af dori-af left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed comments. Please approve the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants