Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix closing sessions" #6300

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xingyaoww
Copy link
Collaborator

@xingyaoww xingyaoww commented Jan 16, 2025

Reverts #6114

This merged PR is causing issue with /download endpoint hence causing our CI to fail now.

e.g., This commit adds new testcases that relies on copy_from method that uses /download.

CI error: https://github.com/All-Hands-AI/OpenHands/actions/runs/12793391296/job/35666481217

I just locally reproduced this, it seems after reverting this PR, the test started to work. With this commits, the zip downloaded from runtime has a size of 0B.

Originally posted by @xingyaoww in #6114 (comment)


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:009a492-nikolaik   --name openhands-app-009a492   docker.all-hands.dev/all-hands-ai/openhands:009a492

@xingyaoww xingyaoww requested review from tofarr and rbren January 16, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant