Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no forwarding if primary url own #1022

Conversation

jjaakola-aiven
Copy link
Contributor

About this change - What it does

References: #xxxxx

Why this way

@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-fastapi-no-forward-if-primary-url-own branch 6 times, most recently from 86979ac to 0ee3164 Compare January 13, 2025 13:32
Copy link

github-actions bot commented Jan 13, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/karapace
  config.py
  rapu.py
  typing.py
  src/karapace/coordinator
  master_coordinator.py 169, 183
  schema_coordinator.py
  src/schema_registry
  controller.py 834-835, 866
  reader.py
  registry.py 98-107
  src/schema_registry/routers
  config.py 93-96, 117-120
  master_availability.py 43-44, 52-54
  subjects.py 9-10, 86-91, 169-174
Project Total  

This report was generated by python-coverage-comment-action

@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-fastapi-no-forward-if-primary-url-own branch from 0ee3164 to 2259716 Compare January 13, 2025 13:55
@jjaakola-aiven jjaakola-aiven marked this pull request as ready for review January 14, 2025 10:57
@jjaakola-aiven jjaakola-aiven requested review from a team as code owners January 14, 2025 10:57
src/karapace/config.py Show resolved Hide resolved
src/karapace/coordinator/master_coordinator.py Outdated Show resolved Hide resolved
src/schema_registry/registry.py Outdated Show resolved Hide resolved
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-fastapi-no-forward-if-primary-url-own branch from 1c61424 to a19605a Compare January 15, 2025 11:51
Copy link
Contributor

@keejon keejon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@keejon keejon merged commit 3b059c8 into jjaakola-aiven-fastapi Jan 15, 2025
10 checks passed
@keejon keejon deleted the jjaakola-aiven-fastapi-no-forward-if-primary-url-own branch January 15, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants