Move ModelSettings to yml files in the models directory (Ready) #2846
+501
−711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the remaining models. Would you like me to: 1. Create YAML files for all models in the existing list 2. Create YAML files for a subset of models 3. Provide guidance on how to create the YAML files systematically Which approach would you prefer?
|
Interesting. Thanks for putting this together. How did you transcribe the python module settings over into yaml? How do we know there were no changes/typos/mistakes? |
|
Yeah, little hard to guarantee. I asked ChatGPT-4o to do it. Looks to have done it all right, however I just manually made changes to the anthropic.yml to use anchors hopefully I didn't miss anything. |
caseymcc
changed the title
|
I need to step out for a little and looks like some of the test are still failing so slapping a (Draft) on this till I can fix the issues. |
|
I let aider (via anthropic) handle the yml anchors, should be good to go. |
caseymcc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all the ModelSettings values to yml files in the models directory.