Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Optimise ModelSettings configs and retrieval #2821

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: Optimise ModelSettings configs and retrieval #2821

wants to merge 3 commits into from

Conversation

Finndersen
Copy link

@Finndersen Finndersen commented Jan 10, 2025 •
edited
Loading

Changes:

  • simplify detection of OpenAI or Anthropic models by removing OPENAI_MODELS and ANTHROPIC_MODELS lists which are a burden to maintain
  • optimise Model Settings retrieval by turning MODEL_SETTINGS into a dict. Always use provider prefix in model names (user can still provide name without prefix), and remove duplicate configurations.
  • Simplify weak_model and editor_model configuration, and add tests
  • rename model to model_name for clarity

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Finndersen @CLAassistant