Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for VFX Platform 2024 containers #186

Merged

Conversation

jfpanisset
Copy link
Contributor

See CHANGELOG.md for list of new versions

Some highlights:

  • alembic, pybind11, qt, pyside are now Conan builds only
  • clang 15 and 16
  • CUDA 12.3, OptiX 8
  • conan package dependencies correctly versions locked
  • conan packages now export all their CMake files and can be consumed by CMake outside Conan
  • some Conan package tests disabled for now

See CHANGELOG.md for list of new versions

Signed-off-by: Jean-Francois Panisset <[email protected]>
@jfpanisset jfpanisset marked this pull request as draft January 31, 2024 04:05
@lgritz
Copy link
Contributor

lgritz commented Jan 31, 2024

NOT A PRIORITY for near term, but next time you're adjusting versions, current llvm is 17 and 18 is maybe a month or so away. Unless somebody needs 15/16 in this container, probably should think about 17/18 as the modern versions for 2024.

@jfpanisset
Copy link
Contributor Author

Would 16/17 make sense? I'd like to get a release out ASAP.

I seem there was some discussion of the transition to 17 being a bit tricky for OSL since it relied on infrastructure that was changing quite a bit in llvm 17, has that issue been addressed?

@lgritz
Copy link
Contributor

lgritz commented Jan 31, 2024

Long since fixed. OSL tests on 17 as part of its CI. At least for OSL 1.13 that will be released in the next couple days.

I would say (at your convenience): definitely add 17, I would remove 15 but keep if somebody else says they need it, I'm neutral on 16.

@lgritz
Copy link
Contributor

lgritz commented Jan 31, 2024

For the sake of getting a release out soon, by all means go with what you have now.

I just meant, next time you revisit...

@jfpanisset
Copy link
Contributor Author

Swapping out LLLVM 17.0.1 for 15, the timing makes it worth the effort

LLVM 17.0.1 is our, let's switch to LLVM 16.0.4 and 17.0.1

Signed-off-by: Jean-Francois Panisset <[email protected]>
common-4 builds with llvm 16 and 17

Signed-off-by: Jean-Francois Panisset <[email protected]>
Missing common_version variable
Build against LLVM 17 by default

Signed-off-by: Jean-Francois Panisset <[email protected]>
Signed-off-by: Jean-Francois Panisset <[email protected]>
- OIIO 2.5.8.0
- OSL 1.13.6.1 to support llvm 16/17

Signed-off-by: Jean-Francois Panisset <[email protected]>
Signed-off-by: Jean-Francois Panisset <[email protected]>
Signed-off-by: Jean-Francois Panisset <[email protected]>
Signed-off-by: Jean-Francois Panisset <[email protected]>
Signed-off-by: Jean-Francois Panisset <[email protected]>
Signed-off-by: Jean-Francois Panisset <[email protected]>
Signed-off-by: Jean-Francois Panisset <[email protected]>
Signed-off-by: Jean-Francois Panisset <[email protected]>
Signed-off-by: Jean-Francois Panisset <[email protected]>
Signed-off-by: Jean-Francois Panisset <[email protected]>
@jfpanisset jfpanisset marked this pull request as ready for review February 2, 2024 04:18
@jfpanisset jfpanisset requested a review from lgritz February 2, 2024 04:19
Copy link
Contributor

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The choices all seem fine to me

@jfpanisset jfpanisset merged commit 76eec43 into AcademySoftwareFoundation:master Feb 3, 2024
3 of 11 checks passed
@jfpanisset jfpanisset mentioned this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants