2023.2 release #185
2023.2 release #185
Conversation
jfpanisset
commented
Nov 8, 2023
jfpanisset
commented
- Conan builds now use docker cache mounts, no longer get pulled into docker build context, which helps a lot for local builds
- update docker buildx plugin
- OpenVDB and OpenEXR build containers get PyBind11
- use a mirror to download Qt 5.15 faster
- Conan builds now use docker cache mounts, no longer get pulled into docker build context, which helps a lot for local builds - update docker buildx plugin - OpenVDB and OpenEXR build containers get PyBind11 Signed-off-by: Jean-Francois Panisset <[email protected]>
Signed-off-by: Jean-Francois Panisset <[email protected]>
Downloading qt opensource from qt.io will time out CI builds, use funet.fi mirror instead (was already in Conan recipe) Signed-off-by: Jean-Francois Panisset <[email protected]>
Signed-off-by: Jean-Francois Panisset <[email protected]>
| # if version_info.ci_common_version != major_version: | ||
| # # Only bake conan images in ci_common container! | ||
| # version = version_info.ci_common_version | ||
| # major_version = utils.get_major_version(version) |
There was a problem hiding this comment.
Should this whole block be removed?
There was a problem hiding this comment.
I went back and forth on this one several times, but I think now with the "building Conan packages in buildx" support, this is no longer valid, so I'll get rid of the block altogether.
| @@ -35,7 +35,7 @@ def test_package_baseqt_2019_dict(self): | |||
| qt_version = list( | |||
| index.Index().iter_versions(constants.ImageType.PACKAGE, "qt") | |||
| )[0] | |||
| baked = b.make_bake_dict() | |||
| baked = b.make_bake_dict(False, False, False, False) | |||
There was a problem hiding this comment.
I usually prefer defining default arg value on the function, and specify non-default args when needed using my_arg=True, my_other_arg=True as the False, False, False, False combo isn't very informative
There was a problem hiding this comment.
I was trying to go for "minimum footprint" changes and wasn't very clear on how best to propagate these parameters. I'll update the function signature accordingly.
| d = self.make_bake_dict() | ||
| def make_bake_jsonfile( | ||
| self, | ||
| keep_source: bool, |
There was a problem hiding this comment.
You could make this function keyword only to avoid confusion on what does the Boolean does. You can do it by putting a * as argument before keep_source. This with default values makes it easier to use and less error prone
|
I will merge as is so I can make some releases and address the comments in a follow up branch, thank you very much! |
jfpanisset
merged commit d6f74a5
into
AcademySoftwareFoundation:master
