#1680 fix segmentation fault when appending None

[semagnum]

Fixes #1680

Summary

Changes to reference parameter to raise TypeError instead of crashing with a segmentation fault. Created test_append_none to prevent regression.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: semagnum / name: Spencer Magnusson (6114856)

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.70%. Comparing base (c0e97b0) to head (6114856).
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1778      +/-   ##
==========================================
- Coverage   84.11%   81.70%   -2.41%     
==========================================
  Files         198      176      -22     
  Lines       22241    12318    -9923     
  Branches     4687     3028    -1659     
==========================================
- Hits        18709    10065    -8644     
+ Misses       2610     1717     -893     
+ Partials      922      536     -386     

Flag	Coverage Δ
py-unittests	81.70% <80.00%> (-2.41%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...entimelineio-bindings/otio_serializableObjects.cpp	93.66% <100.00%> (-0.20%)	⬇️
tests/test_track.py	93.47% <66.66%> (-1.88%)	⬇️

... and 65 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e10fdd2...6114856. Read the comment docs.

[ssteinbach]

Just to make sure I understand- because it was pointer before, you could pass the python None value, which would coerce to a nullptr and then cause a segfault when adding. By switching to a ref, pybind disallows nullptr/None and raises a TypeError?

[ssteinbach]

LGTM, good catch

[meshula]

good solution, thanks