Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Switch to a 2-level namespace #1922

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Jan 15, 2025

Related OIIO PR: AcademySoftwareFoundation/OpenImageIO#4567

Like in the corresponding OIIO PR, I'm proposing switching to a 2-level namespace scheme (basically, OSL::v1_14 instead of the current `OSL_v1_14) because that opens the door to possible future schemes to preserve better ABI compatibility between minor releases.

I would like to squeeze this in before I finalize a 1.14 beta, so that it doesn't change again during the beta period.

Also, I changed some macro names.

Related OIIO PR: AcademySoftwareFoundation/OpenImageIO#4567

Like in the corresponding OIIO PR, I'm proposing switching to a
2-level namespace scheme (basically, `OSL::v1_14` instead of the
current `OSL_v1_14) because that opens the door to possible future
schemes to preserve better ABI compatibility between minor releases.

I would like to squeeze this in before I finalize a 1.14 beta, so that
it doesn't change again during the beta period.

Also, I changed some macro names.

Signed-off-by: Larry Gritz <[email protected]>
@lgritz
Copy link
Collaborator Author

lgritz commented Jan 15, 2025

Please excuse the fact that this touches every source file. Almost all the individual changes are the result of changing OSL_NAMESPACE_ENTER/EXIT to OSL_NAMESPACE_BEGIN/END, which I did to match other projects including OIIO. The substantive changes are only to CMakeLists.txt and oslversion.in.h.

@lgritz lgritz merged commit 42ccf22 into AcademySoftwareFoundation:main Jan 16, 2025
21 of 22 checks passed
@lgritz lgritz deleted the lg-ns2level branch January 16, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants