Skip to content

Commit

Permalink
build: Bump Cuda minimum to 9.0 (#1737)
Browse files Browse the repository at this point in the history
Based on Brecht's tests, we realize that OSL doesn't work at all with
Cuda 8.0 (which didn't support the C++14 that we use), so we're
raising the minimum to 9.0. And there are some flaky tests with 9 and
10, so we're making the recommended minimum be 11.0.

It's not our policy to change the minimum versions of dependencies on
release branches, but I think we should backport this to the release
branch. I believe what this change is doing is not removing actual
support for old versions, but rather, correctly documenting what has
been working (or not) for quite some time.

---------

Signed-off-by: Larry Gritz <[email protected]>
Co-authored-by: Brecht Van Lommel <[email protected]>
  • Loading branch information
lgritz and brechtvl committed Oct 5, 2023
1 parent facfe0b commit c59d74f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion INSTALL.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ NEW or CHANGED dependencies since the last major release are **bold**.
on the OSL side to be compatible.

* (optional) For GPU rendering on NVIDIA GPUs:
* [Cuda](https://developer.nvidia.com/cuda-downloads) 8.0 or higher.
* [Cuda](https://developer.nvidia.com/cuda-downloads) 9.0 or higher.
* [OptiX](https://developer.nvidia.com/rtx/ray-tracing/optix) 5.1 or higher
(though 7.0+ is highly recommended).

Expand Down
7 changes: 5 additions & 2 deletions src/cmake/externalpackages.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,11 @@ if (USE_CUDA OR USE_OPTIX)
endif ()

checked_find_package (CUDA REQUIRED
VERSION_MIN 8.0
PRINT CUDA_INCLUDES)
VERSION_MIN 9.0
RECOMMEND_MIN 11.0
RECOMMEND_MIN_REASON
"We don't actively test CUDA older than 11"
PRINT CUDA_INCLUDES)
set (CUDA_INCLUDES ${CUDA_TOOLKIT_ROOT_DIR}/include)
include_directories (BEFORE "${CUDA_INCLUDES}")

Expand Down

0 comments on commit c59d74f

Please sign in to comment.