Fix OCIO SYNDisplay/SYNLinearize nodes causing freeze #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernard Laberge <[email protected]>
bernie-laberge
requested review from
eloisebrosseau and
cedrik-fuoco-adsk
as code owners
eloisebrosseau
approved these changes
Jan 15, 2025
cedrik-fuoco-adsk
approved these changes
Jan 16, 2025
bernie-laberge
merged commit 45e5bae
into
AcademySoftwareFoundation:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix OCIO SYNDisplay/SYNLinearize nodes causing freeze
Linked issues
NA
Summarize your change.
Make the mutex (QMutex) used by OCIOIPNode recursive.
Describe the reason for the change.
Prior to this fix, using an OCIO SYNDisplay or SYNLinearize nodes was freezing OpenRV.
This was an unexpected regression of a previous fix : 3ec54d2
The problem was that the OCIO SYNDisplay/SYNLinearize were locking the same mutex twice by design, thus leading to the freeze.
Describe what you have tested and on which operating system.
Successfully tested on macOS
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.