-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add footnote about colors being in-gamut (i.e. components in [0,1]) #208
base: dev_1.2
Are you sure you want to change the base?
Add footnote about colors being in-gamut (i.e. components in [0,1]) #208
Conversation
@anderslanglands and @KelSolaar Would appreciate your thoughts on whether this change makes sense. |
It might also be: "... all RGB colours are in-gamut of the working space, i.e., have components in the
|
OK, so in your view "in-gamut" (of the working color space of the shader) simply means that the color components are non-negative?
Can you clarify what you mean by container? We say in the spec that "A color3 value is associated with a color space ACEScg by default" and that "The assumed color space of all the color parameters .. by default .. is assumed to be ACEScg". So "in-gamut" is implied to mean in-gamut of that color space (or ACEScg if unspecified). Is that still under-specified in your view?
Yes right, so emission color should not be restricted to [0,1], but it seemed like according to our earlier discussion we had agreed that for all the other colors, which represent albedos or fractional tints, they should be restricted to [0,1] (regardless of the color space). Do you still agree with that? |
Yes, e.g., HDR values are considered in-gamut of their colourspace for example.
I would certainly be very specific, there is an infinity of gamuts and it does not cost much to add.
Yes! |
Sorry can you clarify what you mean by “there is an infinity of gamuts”? We say the color space must be specified (or is ACEScg by default). How can we be more specific that that? |
We are splitting hairs here but "gamut" by definition (Oxford Languages) is "the complete range or scope of something", what I'm saying is that the notes does not explicitly specifies it.
This is better because the "something" is specified explicitly in the sentence right next to "gamut" and you do not have to reach the end of the sentence to understand the full context. In theory, the i.e., portion of the sentence could be omitted and the sentence would be explicit by itself, I could only write:
|
@jstone-lucasfilm can be merged? |
# Conflicts: # index.html # parametrization.md.html
Based on the interesting discussion in #149, it seems worth adding this side note: