Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exr: add multi-layer image for oiio test suite #9

Closed
wants to merge 1 commit into from

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Jan 13, 2025

Description

Add a simple EXR image with multiple channel-name-based layers for testing oiiotool's new --layersplit command, introduced in this PR: AcademySoftwareFoundation/OpenImageIO#4591

This image was generated with oiiotool, following the command line suggested in this comment: AcademySoftwareFoundation/OpenImageIO#4546 (comment)

@lgritz
Copy link
Contributor

lgritz commented Jan 13, 2025

It LGTM, but usually OpenImageIO-images is for very large files or rarely needed file formats, to avoid bloating the main OpenImageIO repo with items that aren't strictly necessary to build for most users. At a mere 672 bytes, should example this just be directly checked into the main repo in the src subdirectory of whatever test you will use it for? Or even create it on the fly with oiiotool as part of that test, with no permanent version being checked in anywhere?

@mugulmd
Copy link
Contributor Author

mugulmd commented Jan 14, 2025

It LGTM, but usually OpenImageIO-images is for very large files or rarely needed file formats, to avoid bloating the main OpenImageIO repo with items that aren't strictly necessary to build for most users. At a mere 672 bytes, should example this just be directly checked into the main repo in the src subdirectory of whatever test you will use it for? Or even create it on the fly with oiiotool as part of that test, with no permanent version being checked in anywhere?

Ah right that makes sense ! We can definitely put it directly in the oiio PR, that makes one less PR :)

@mugulmd mugulmd closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants