Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments for HIP #462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpola-amd
Copy link

Hi,

I would like to propose some small adjustments for HIP/ROCm platforms that I found necessary during my experiments with the OSL.

Copy link

CLA Not Signed

@cary-ilm
Copy link
Member

Catching up on this after being away. This looks fine, thanks for the contribution. Our project policy is to require signed commits (DCO) and a contributor license agreement, even for relatively trivial contributions.

For the DCO, you can amend the commit to add the signature by adding -s:

git commit --amend -s
git push --force

To sign the CLA, click the red "NOT COVERED" button and sign the form.

If this is too much of a hassle, I can replicate the change myself when I get a chance. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants